Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Format numeric tags nicely in explore #81255

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Zylphrex
Copy link
Member

Some tags may not have loaded or is from a different project. In thise case, we should try to render them nicely.

Some tags may not have loaded or is from a different project. In thise case, we
should try to render them nicely.
@Zylphrex Zylphrex requested a review from a team as a code owner November 25, 2024 18:13
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/explore/toolbar/toolbarSortBy.tsx 72.22% 5 Missing ⚠️
static/app/views/explore/components/typeBadge.tsx 66.66% 1 Missing ⚠️
...tic/app/views/explore/toolbar/toolbarVisualize.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81255      +/-   ##
==========================================
- Coverage   80.34%   80.34%   -0.01%     
==========================================
  Files        7219     7220       +1     
  Lines      319544   319582      +38     
  Branches    20779    20785       +6     
==========================================
+ Hits       256736   256759      +23     
- Misses      62417    62429      +12     
- Partials      391      394       +3     

@Zylphrex Zylphrex merged commit 0661d41 into master Nov 25, 2024
44 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/format-numeric-tags-nicely-in-explore branch November 25, 2024 20:29
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
Some tags may not have loaded or is from a different project. In thise
case, we should try to render them nicely.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants