Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update JavaScript SDK to v7.47.0 #2958

Merged
merged 10 commits into from
Apr 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 6, 2023

Bumps scripts/update-javascript.sh from 7.46.0 to 7.47.0.

Auto-generated by a dependency updater.

Changelog

7.47.0

Important Changes

  • feat(browser): Add captureUserFeedback (#7729)

This release adds a new API, Sentry.captureUserFeedback, to browser-side SDKs that allows you to send user feedback to Sentry without loading and opening Sentry's user feedback dialog. This allows you to obtain user feedback however and whenever you want to and simply send it to Sentry using the SDK.

For instance, you can collect feedback, whenever convenient as shown in this example:

const eventId = Sentry.captureMessage('User Feedback');
const user = Sentry.getCurrentHub().getScope().getUser();
const userFeedback = {
  event_id: eventId;
  email: user.email
  name: user.username
  comments: 'I really like your App, thanks!'
}
Sentry.captureUserFeedback(userFeedback);

Note that feedback needs to be coupled to an event but as in the example above, you can just use Sentry.captureMessage to generate one.

You could also collect feedback in a custom way if an error happens and use the SDK to send it along:

Sentry.init({
  dsn: '__DSN__',
  beforeSend: event => {
    const userFeedback = collectYourUserFeedback();
    const feedback = {
      ...userFeedback,
      event_id: event.event_id.
    }
    Sentry.captureUserFeedback(feedback);
    return event;
  }
})
  • feat(tracing): Deprecate sentry/tracing exports (#7611)

With this release, we officially deprecate all exports from the sentry/tracing package, in favour of using them directly from the main SDK package. The sentry/tracing package will be removed in a future major release.

Please take a look at the Migration docs for more details.

Additional Features and Fixes

  • feat(sveltekit): Add partial instrumentation for client-side fetch (#7626)
  • fix(angular): Handle routes with empty path (#7686)
  • fix(angular): Only open report dialog if error was sent (#7750)
  • fix(core): Determine debug ID paths from the top of the stack (#7722)
  • fix(ember): Ensure only one client is created & Replay works (#7712)
  • fix(integrations): Ensure HttpClient integration works with Axios (#7714)
  • fix(loader): Ensure JS loader works with tracing & add tests (#7662)
  • fix(nextjs): Restore tree shaking capabilities (#7710)
  • fix(node): Disable LocalVariables integration on Node < v18 (#7748)
  • fix(node): Redact URL authority only in breadcrumbs and spans (#7740)
  • fix(react): Only show report dialog if event was sent to Sentry (#7754)
  • fix(remix): Remove unnecessary dependencies (#7708)
  • fix(replay): Ensure circular references are handled (#7752)
  • fix(sveltekit): Don't capture thrown Redirects as exceptions (#7731)
  • fix(sveltekit): Log error to console by default in handleErrorWithSentry (#7674)
  • fix(tracing): Make sure idle transaction does not override other transactions (#7725)

Work in this release contributed by de-don and TrySound. Thank you for your contributions!

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 6, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-javascript.sh branch from bed42f1 to 1b85655 Compare April 6, 2023 03:05
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 6, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 376.65 ms 387.67 ms 11.02 ms
Size 17.73 MiB 19.75 MiB 2.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms

App size

Revision Plain With Sentry Diff
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
04349b0+dirty 347.00 ms 354.78 ms 7.78 ms
6750c69+dirty 393.45 ms 434.06 ms 40.62 ms
98fe518+dirty 334.39 ms 349.35 ms 14.96 ms

App size

Revision Plain With Sentry Diff
04349b0+dirty 17.73 MiB 20.06 MiB 2.32 MiB
6750c69+dirty 17.73 MiB 20.05 MiB 2.32 MiB
98fe518+dirty 17.73 MiB 19.75 MiB 2.02 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 6, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.88 ms 1270.92 ms 13.04 ms
Size 2.36 MiB 2.84 MiB 487.00 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms

App size

Revision Plain With Sentry Diff
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB

Previous results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
04349b0+dirty 1273.22 ms 1281.90 ms 8.68 ms
6750c69+dirty 1242.69 ms 1256.00 ms 13.31 ms
98fe518+dirty 1251.16 ms 1262.00 ms 10.84 ms

App size

Revision Plain With Sentry Diff
04349b0+dirty 2.36 MiB 2.83 MiB 480.92 KiB
6750c69+dirty 2.36 MiB 2.83 MiB 477.50 KiB
98fe518+dirty 2.36 MiB 2.83 MiB 481.64 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 6, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1289.45 ms 1304.54 ms 15.09 ms
Size 2.92 MiB 3.40 MiB 493.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms

App size

Revision Plain With Sentry Diff
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB

Previous results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
04349b0+dirty 1241.88 ms 1258.20 ms 16.32 ms
6750c69+dirty 1285.45 ms 1285.86 ms 0.41 ms
98fe518+dirty 1259.43 ms 1263.60 ms 4.17 ms

App size

Revision Plain With Sentry Diff
04349b0+dirty 2.92 MiB 3.40 MiB 487.96 KiB
6750c69+dirty 2.92 MiB 3.39 MiB 484.54 KiB
98fe518+dirty 2.92 MiB 3.40 MiB 488.60 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 6, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 268.02 ms 333.17 ms 65.15 ms
Size 7.15 MiB 8.04 MiB 911.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms

App size

Revision Plain With Sentry Diff
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB

Previous results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
04349b0+dirty 333.83 ms 366.86 ms 33.02 ms
6750c69+dirty 277.10 ms 322.10 ms 45.00 ms
98fe518+dirty 334.79 ms 372.23 ms 37.44 ms

App size

Revision Plain With Sentry Diff
04349b0+dirty 7.15 MiB 8.10 MiB 977.92 KiB
6750c69+dirty 7.15 MiB 8.10 MiB 971.75 KiB
98fe518+dirty 7.15 MiB 8.04 MiB 911.30 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-javascript.sh branch 5 times, most recently from 66e1574 to 98603b7 Compare April 11, 2023 08:41
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-javascript.sh branch from 98603b7 to 154c456 Compare April 11, 2023 09:23
src/js/index.ts Outdated Show resolved Hide resolved
@krystofwoldrich
Copy link
Member

@marandaneto I've made some changes to fix the lint and remove the deprecated @sentry/tracing. Could you review it? 🙏

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-javascript.sh branch from 761723c to 267ba2d Compare April 12, 2023 03:03
@krystofwoldrich
Copy link
Member

@AbhiPrasad Since you've already tried to remove @sentry/tracing from RN, maybe you would like to see this.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

startIdleTransaction,
} from '@sentry/tracing';
import type { RequestInstrumentationOptions } from '@sentry-internal/tracing';
import { instrumentOutgoingRequests } from '@sentry-internal/tracing';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we need to export this from @sentry/browser! With that we can remove @sentry-internal/tracing usage as well :)

I'll take care of making that fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be nice. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants