feat(sveltekit): Read adapter output directory from svelte.config.js
#7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Apr 14, 2023
| @@ -37,7 +37,7 @@ const DEFAULT_PLUGIN_OPTIONS: SentrySvelteKitPluginOptions = { | |||
| * Sentry adds a few additional properties to your Vite config. | |||
| * Make sure, it is registered before the SvelteKit plugin. | |||
| */ | |||
| export function sentrySvelteKit(options: SentrySvelteKitPluginOptions = {}): Plugin[] { | |||
| export async function sentrySvelteKit(options: SentrySvelteKitPluginOptions = {}): Promise<Plugin[]> { | |||
There was a problem hiding this comment.
This is technically breaking as it changes the return type of the function but the good news is that noone has to await this function as the vite config is perfectly fine with taking a Promise<Plugin[]>. I should have done this already but for some reason decided to stay sync in #7811. I vote we go forward with making it async, not just because we need it for this change but also because it gives us more freedom in the future.
Also, we're still in alpha, so yolo...
Lms24
requested review from
a team,
mydea and
AbhiPrasad
and removed request for
a team
AbhiPrasad
approved these changes
Apr 17, 2023
Yeah this is a great point! We really should start thinking about E2E/Integration tests soon. |
Lms24
force-pushed
the
lms/sveltekit-read-svelte-adapter-config
branch
from
1b221b2 to
0510596
Compare
Lms24
force-pushed
the
lms/sveltekit-read-svelte-adapter-config
branch
from
0510596 to
09891d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #7862
With this PR, our source maps upload plugin is able to read
svelte.config.js. This is necessary to automatically find the output directory that users can specify when setting up the Node adapter.This is a "little" hacky though, because we can't just access the output dir variable. Instead, we actually invoke the adapter (which we can access) and pass a minimal, mostly no-op adapter builder, which will report back the output directory.
(I'm sure this is gonna backfire some day but let's just do it anyway lol)
the good news:
closes #7669