Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serverless): Account when transaction undefined #7829

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix(serverless): Account when transaction undefined #7829

merged 1 commit into from
Apr 13, 2023

Conversation

AbhiPrasad
Copy link
Member

Fixes #7826

If tracing extensions are not added, make sure we identify that hub.startTransaction can return undefined.

@getsentry getsentry deleted a comment from github-actions bot Apr 12, 2023
@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team April 13, 2023 11:45
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 13, 2023
Merged
lforst
lforst approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugly but you gotta do what you gotta do

@AbhiPrasad AbhiPrasad merged commit d324516 into develop Apr 13, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-serverless-optional branch April 13, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sentry/serverless "Cannot read properties of undefined (reading 'finish')" since 7.45.0
3 participants
@AbhiPrasad @lforst @Lms24