Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Only call applyDebugMetadata for error events #7824

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 12, 2023

We're calling this function for transactions right now which doesn't make sense at all and actually is very performance heavy for people that have debug IDs configured.

@lforst lforst requested review from AbhiPrasad and mitsuhiko April 12, 2023 11:18
@lforst lforst marked this pull request as ready for review April 12, 2023 11:18
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.94 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.46 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.5 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 57.9 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.1 KB (+0.04% 🔺)
@sentry/browser - Webpack (minified) 68.85 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.13 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.9 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.5 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.74 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.89 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.85 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.79 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.82 KB (+0.02% 🔺)

@lforst lforst merged commit 4ff4066 into develop Apr 12, 2023
@lforst lforst deleted the lforst-only-apply-debug-metadata-to-error-events branch April 12, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants