Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add getReplayId() method #7822

Merged
merged 2 commits into from
Apr 12, 2023
Merged

feat(replay): Add getReplayId() method #7822

merged 2 commits into from
Apr 12, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 12, 2023

This adds a public getReplayId() method to the replay integration to get the ID of the ongoing session.

Closes #7795

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Apr 12, 2023
@mydea mydea requested review from billyvg and Lms24 April 12, 2023 10:50
@mydea mydea self-assigned this Apr 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.98 KB (+0.07% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.56 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.53 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.13 KB (+0.07% 🔺)
@sentry/browser - Webpack (minified) 68.95 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.15 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.95 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.54 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.77 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.93 KB (+0.04% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.82 KB (+0.05% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.86 KB (+0.05% 🔺)

@pckilgore
Copy link

Doesn't directly address my issue because I still manually need to construct URLs with the IDs, but helpful nonetheless, thank you!

@mydea mydea force-pushed the fn/getSessionId branch from 86d4a09 to 3d2fee7 Compare April 12, 2023 14:02
@mydea mydea changed the title feat(replay): Add getSessonId() method feat(replay): Add getReplayId() method Apr 12, 2023
@mydea mydea force-pushed the fn/getSessionId branch from 3d2fee7 to 2956dc0 Compare April 12, 2023 14:03
@mydea
Copy link
Member Author

mydea commented Apr 12, 2023

Doesn't directly address my issue because I still manually need to construct URLs with the IDs, but helpful nonetheless, thank you!

Yeah, the idea is to unblock this with a public API (building the URL is tricky as we don't necessarily know about where the UI is hosted etc). To at least enable to do this yourself without using private APIs!

@mydea mydea merged commit 371f80d into develop Apr 12, 2023
@mydea mydea deleted the fn/getSessionId branch April 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay: method to extract replayId from SDK
3 participants