Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add DSC to all outgoing envelopes #7820

Merged
merged 5 commits into from
Apr 12, 2023
Merged

feat(core): Add DSC to all outgoing envelopes #7820

merged 5 commits into from
Apr 12, 2023

Conversation

AbhiPrasad
Copy link
Member

Closes #7819

@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team April 12, 2023 10:22
mydea
mydea approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this seems pretty straightforward!

@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 12, 2023 10:25
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.96 KB (+0.09% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.52 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.5 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 57.96 KB (+0.14% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.11 KB (+0.07% 🔺)
@sentry/browser - Webpack (minified) 68.91 KB (+0.11% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.13 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.91 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.52 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.75 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.91 KB (+0.06% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.85 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.79 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.83 KB (+0.02% 🔺)

lforst
lforst approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew it was easier than I thought :p

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) April 12, 2023 12:44
@AbhiPrasad AbhiPrasad merged commit 943df92 into develop Apr 12, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-dsc-on-all branch April 12, 2023 12:59
@mattjohnsonpint mattjohnsonpint mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding the DSC to all envelope headers
3 participants
@AbhiPrasad @mydea @lforst