Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sveltekit): Remove withSentryViteConfig #7789

Merged
merged 1 commit into from
Apr 7, 2023
Merged

feat(sveltekit): Remove withSentryViteConfig #7789

merged 1 commit into from
Apr 7, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 7, 2023

This PR removes the withSentryViteConfig wrapper in favour of sentrySvelteKitPlugin introduced in #7788.

ref #7787

@Lms24 Lms24 requested review from lforst and AbhiPrasad April 7, 2023 13:33
@Lms24 Lms24 self-assigned this Apr 7, 2023
@Lms24 Lms24 mentioned this pull request Apr 7, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.94 KB (+0.08% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.44 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.49 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 57.88 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.11 KB (+0.06% 🔺)
@sentry/browser - Webpack (minified) 68.87 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.14 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.9 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.5 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.73 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.89 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.85 KB (-0.06% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.78 KB (-0.05% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.82 KB (-0.05% 🔽)

@Lms24 Lms24 merged commit d099af8 into develop Apr 7, 2023
@Lms24 Lms24 deleted the lms/sveltekit-remove-withsentryviteconfig branch April 7, 2023 13:54
@Lms24 Lms24 mentioned this pull request Apr 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst lforst approved these changes

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lms24 @lforst @AbhiPrasad