feat(node): Adds domain implementation of AsyncContextStrategy
#7767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
setDomainAsyncContextStrategyto the Node SDK which when called enables a domain based async strategy.This required adding and exporting
ensureHubOnCarrierfrom core which ensures the async context starts off with a base hub copied from the global hub. To move this code outside of core, bothhasHubOnCarrierandAPI_VERSIONwould need to be exported.I also removed the pass-through of
...args: A[])inrunWithAsyncContextand simplified the types since there is no need to pass them through. We only need to pass the references so they can be added to the domain.There are some tests adapted from the previous domain tests that suggest that it functions as it should.