Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Log warning when tracing extensions are missing #7601

Merged
merged 9 commits into from
Apr 11, 2023
Merged

fix(core): Log warning when tracing extensions are missing #7601

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
50f1a90
Throw error when extension methods are missing
timfish Mar 23, 2023
8366d91
shorter
timfish Mar 23, 2023
e635e55
shorter still
timfish Mar 23, 2023
e1a0eb1
Only throw in debug mode and startTransaction
timfish Mar 27, 2023
0710db9
revert change
timfish Mar 27, 2023
52cc1bc
Merge remote-tracking branch 'upstream/develop' into feat/missing-tra…
timfish Mar 27, 2023
1d70a47
Merge branch 'develop' into feat/missing-tracing-throw
timfish Mar 27, 2023
716836c
console.warn rather than throw
timfish Apr 9, 2023
e6dc466
Merge branch 'develop' into feat/missing-tracing-throw
timfish Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions packages/core/src/hub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,17 @@ export class Hub implements HubInterface {
* @inheritDoc
*/
public startTransaction(context: TransactionContext, customSamplingContext?: CustomSamplingContext): Transaction {
return this._callExtensionMethod('startTransaction', context, customSamplingContext);
const result = this._callExtensionMethod<Transaction>('startTransaction', context, customSamplingContext);

if (__DEBUG_BUILD__ && !result) {
throw new Error(`Tracing extension 'startTransaction' has not been added. Call 'addTracingExtensions' before calling 'init':
timfish marked this conversation as resolved.
Show resolved Hide resolved

Sentry.addTracingExtensions();
Sentry.init({...});
`);
}

return result;
}

/**
Expand Down Expand Up @@ -480,7 +490,15 @@ export class Hub implements HubInterface {
if (sentry && sentry.extensions && typeof sentry.extensions[method] === 'function') {
return sentry.extensions[method].apply(this, args);
}
__DEBUG_BUILD__ && logger.warn(`Extension method ${method} couldn't be found, doing nothing.`);
throw new Error(`Tracing extension '${method}' has not been added.
Call 'addTracingExtensions' before calling 'init':

Sentry.addTracingExtensions();

Sentry.init({
...
});
`);
}
}

Expand Down