Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): Ensure browser bundle exists before running tests #4389

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

lobsterkatie
Copy link
Member

The tests in our wasm package use the browser bundle, and therefore won't run if the bundle hasn't been built. #4074 added a warning for this situation. This PR improves that by actually building the missing bundles, ensuring the tests will always run.

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (e52faa4) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.77 KB 19.77 KB +0.02% 🔺
@sentry/browser - CDN Bundle (minified) 62.94 KB 62.94 KB +0.01% 🔺
@sentry/browser - Webpack 22.31 KB 22.31 KB 0%
@sentry/browser - Webpack - gzip = false 76.19 KB 76.19 KB 0%
@sentry/react - Webpack 22.34 KB 22.34 KB 0%
@sentry/nextjs Client - Webpack 46.48 KB 46.48 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.43 KB 28.43 KB +0.02% 🔺

@lobsterkatie lobsterkatie changed the title fix(wasm): Create browser bundle if missing before running tests fix(wasm): Ensure browser bundle exists before running tests Jan 12, 2022
@lobsterkatie lobsterkatie merged commit d53ed78 into master Jan 12, 2022
@lobsterkatie lobsterkatie deleted the kmclb-ensure-browser-bundle-for-wasm-tests branch January 12, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants