Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): Add build:dev options to CONTRIBUTING.md #4055

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

lobsterkatie
Copy link
Member

This updates CONTRIBUTING.md to use the build:dev commands introduced in #4048. It also includes some very minor wordsmithing and a few changes made by the auto-formatter.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.34 KB (+0.01% 🔺)
@sentry/browser - Webpack 23.31 KB (0%)
@sentry/react - Webpack 23.34 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.79 KB (0%)

@lobsterkatie lobsterkatie merged commit e1f4f89 into master Oct 11, 2021
@lobsterkatie lobsterkatie deleted the kmclb-add-build-dev-to-contributing.md branch October 11, 2021 21:36
Since we are using [`TypeScript`](https://www.typescriptlang.org/), you need to transpile the code to JavaScript to be
able to use it. Every package has a `build` script which takes care of everything. You can also run `build` on all of the
packages at once by calling `yarn build` in the project root.
Since we are using [`TypeScript`](https://www.typescriptlang.org/), you need to transpile the code to JavaScript to be able to use it. From the top level of the repo, there are three commands available:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the top level of the repo, there are three commands available:

We still have yarn build to build CDN bundles, why don't include it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants