chore: Some improvements to @sentry/types #3188
Conversation
- JSDocs added - AppContext added - BrowserContext added - DeviceContext added - GpuContext added - OsContext added - RuntimeContext added - StateContext added
- JSDoc added - BreadcrumbTypes added
- JSDoc added - MechanismMeta added
- JSDoc
|
Looks really promising! I'll try to review it on Monday. Thanks @Asesjix! |
|
Hey @Asesjix, thanks for the PR, most of it looks really good, and I'll definitely make sure to use it as a part of v7 work (see: #2817) However, it also contains a lot of unused types, some breaking changes (eg. too restrictive contexts can break compilation for some users if they didn't follow our current dev docs), and some types/interfaces that are not even related to JavaScript (eg. As we are currently focused on developing the next major version, we'd prefer to include those changes there and be certain that no types of issues will arise due to such a large changeset. Once again, really appreciate the contribution, and it definitely won't go to waste :) Cheers! |
|
Closing as stale. |
The PR mostly adds JSDoc and missing types.