fix(browser): Adjust BrowserTransportOptions to support offline tra…

…nsport options (#7775) Our `transportOptions` init field currently isn't typed correctly to accept `BrowserOfflineTransportOptions`, causing type errors when trying to configure the offline transport. This patch fixes this bug by making `BrowserTransportOptions` extend `BrowserOfflineTransportOptions`.
getsentry · Apr 6, 2023 · 4395d74 · 4395d74
1 parent 1ab3477
commit 4395d74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/browser/src/transports/offline.ts b/packages/browser/src/transports/offline.ts
@@ -79,7 +79,7 @@ export function pop(store: Store): Promise<Uint8Array | string | undefined> {
   });
 }
 
-interface BrowserOfflineTransportOptions extends OfflineTransportOptions {
+export interface BrowserOfflineTransportOptions extends OfflineTransportOptions {
   /**
    * Name of indexedDb database to store envelopes in
    * Default: 'sentry-offline'

diff --git a/packages/browser/src/transports/types.ts b/packages/browser/src/transports/types.ts
@@ -1,6 +1,10 @@
 import type { BaseTransportOptions } from '@sentry/types';
 
-export interface BrowserTransportOptions extends BaseTransportOptions {
+import type { BrowserOfflineTransportOptions } from './offline';
+
+type BaseTransportAndOfflineTransportOptions = BaseTransportOptions & BrowserOfflineTransportOptions;
+
+export interface BrowserTransportOptions extends BaseTransportAndOfflineTransportOptions {
   /** Fetch API init parameters. Used by the FetchTransport */
   fetchOptions?: RequestInit;
   /** Custom headers for the transport. Used by the XHRTransport and FetchTransport */