Remove old cached bundle on refresh #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we refresh the cached files for a bundle, delete the old directory so that any files that would not be overwritten, for example the updated bundle doesn't have a relocation mapping file or manifest, are removed.
vdice
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When we refresh the cached files for a bundle, delete the old directory so that any files that would not be overwritten, for example the updated bundle doesn't have a relocation mapping file or manifest, are removed.
What issue does it fix
Fixes #991
Notes for the reviewer
As a follow-up I am working on #992 since per the original issue, they are using
porter explainwhich doesn't have a--forceflag to make it easy for them to repull the bundle and use this fix.Checklist