Stop invoke when claim not found #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During invoke, when we cannot find the requested claim, and it is required for the action, stop immediately and report the error to the user.
carolynvs
force-pushed
the
release-0.24.1-beta.1
branch
from
d19b383 to
6c929e7
Compare
vdice
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Because we have changes in master that aren't ready to go in a release, I am making this a patch against the last release. Note that the branch this PR is open against is
release-0.24.1-beta.1which is the desired next version (I branched off ofv0.24.0-beta.1).To facilitate this PR, I updated our azure pipelines to run against PRs targeting
release-*branches.What issue does it fix
Closes #948
Notes for the reviewer
What the user was really doing was this
Where the uninstallCleanup would do extra work. However since our current implementation deletes the claim, that is why when they called invoke, the claim was missing and they hit this bug. We are waiting on #935 for the long term fix for this problem.
Checklist