Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add best practice for the exec mixin #942

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Add best practice for the exec mixin #942

merged 1 commit into from
Mar 10, 2020

Conversation

carolynvs
Copy link
Member

What does this change

Explain how to use the exec mixin without shooting yourself in the foot.

What issue does it fix

Follow-up to #931

Notes for the reviewer

😝

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@carolynvs-msft
Add best practice for the exec mixin
ed5dd51 
Explain how to use the exec mixin without shooting yourself in the foot.
jeremyrickard
jeremyrickard approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is goodness

@carolynvs carolynvs merged commit 9110c71 into getporter:master Mar 10, 2020
@carolynvs carolynvs deleted the exec-best-practice branch March 10, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard jeremyrickard approved these changes

@vdice vdice vdice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carolynvs @vdice @jeremyrickard @carolynvs-msft