Refactor claims plugin to be a storage plugin #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
credential-plugin
branch
2 times, most recently
from
8ac6766 to
45181c0
Compare
3 tasks
carolynvs
force-pushed
the
credential-plugin
branch
from
45181c0 to
3c59886
Compare
carolynvs
changed the title
Instead of having a credential plugin, and a claims plugin, etc this refactors the plugin POC so that there is a single storage plugin with the intent of being able to offload the entire porter home directory contents (except the config file) to the plugins. For example everything that we currently store today on the filesystem could be stored in blob storage or a database. This replies upon a unmerged branch with changes to the crud.Store interface and other changes to support this. I have also stubbed in a new plugin for secrets, though it isn't completely plumbed through and will be completed in a separate PR. At the moment all secrets, for example the values that we resolve credentials from but could eventually be parameter values too among other things, are coming from a host plugin embedded in porter.
|
It all works. I need to catch up on tests for net new classes and write a bit more doc strings to help explain what's going on. |
vdice
reviewed
Jan 24, 2020
carolynvs
force-pushed
the
credential-plugin
branch
from
3c59886 to
a49e58c
Compare
Use the stame instance of the storage pluginStore between the claims storage and credentials storage.
* Loading from file * Ensure our mapstructure tags are correct * Switch to default-storage-plugin for consistency
|
I have submitted upstream PRs for everything that was in that branch of cnab-go, added tests for all the net new structs and added go docs. I officially declare this turd polished! 🌟 |
This was referenced Jan 30, 2020
vdice
approved these changes
Jan 31, 2020
This was referenced Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Instead of having a credential plugin, and a claims plugin, etc this refactors the plugin POC so that there is a single storage plugin with the intent of being able to offload the entire porter home directory contents (except the config file) to the plugins.
For example everything that we currently store today on the filesystem could be stored in blob storage or a database. For this PR that means credential sets and claims.
This replies upon a unmerged cnab-go branch with changes to the crud.Store interface and other changes to support this.
I have also stubbed in a new plugin for secrets, though it isn't completely plumbed through and will be completed in a separate PR. At the moment all secrets, for example the values that we resolve
credentials from but could eventually be parameter values too among other things, are coming from a host plugin embedded in porter.
What issue does it fix
#866
Notes for the reviewer
Checklist