Rename mixins delete to mixins uninstall #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency we want to use commands that pair together. add/delete pair, but we are using install/delete which (just see helm2) causes people to guess the wrong verb. It's also inconsistent with the verbs we use elsewhere in porter which is already install/uninstall. Sorry, that is my fault when I created the issue for the enhancement!
vdice
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Change
porter mixins deletetoporter mixins uninstallFor consistency we want to use commands that pair together. add/delete pair, but we are using install/delete which (just see helm2) causes people to guess the wrong verb. It's also inconsistent with the verbs we use elsewhere in porter which is already install/uninstall.
Sorry, that is my fault when I created the issue for the enhancement!
What issue does it fix
N/A
Notes for the reviewer
I am going to fix the other command links in the nav in a follow-up issue, I think more are broken. I only fixed the ones related to this PR.
Checklist