fix(test-terraform.sh): remove fragile, redundant file contents check #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell me how you really feel, @vdice 😂 |
|
😂 I've allowed a bit of harshness since I'm responsible for its origins :) |
3 tasks
carolynvs
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Removes a fragile check (based on literal text output which is subject to change) in the terraform portion of the cli test. It is now redundant as we've since added
porter instance outputs listchecks to verify the expected file contents value.What issue does it fix
Fixes the
test-clitarget in CI.Notes for the reviewer
N/A
Checklist