Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packr2 failed to install while running make #668

Merged

Conversation

dev-drprasad
Copy link
Contributor

What does this change

Fix packr2 failed to install while running make

What issue does it fix

Closes #667

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@carolynvs
Copy link
Member

@dev-drprasad It's not clear what the error was that you encountered? I'm looking at the change in the PR and I don't see what problem it would address. Can you provide some more context?

@dev-drprasad
Copy link
Contributor Author

@carolynvs we need shell function to execute commands in make. But it is missing
https://github.com/deislabs/porter/blob/1a5ae4b1dcb506142d98b8de3a30c6fc76151026/Makefile#L53

$(go env GOPATH) resolve to empty string . So, packr2 will get install to /bin which require sudo access. Since we dont run make with sudo, we endup with Operation not permitted

@carolynvs
Copy link
Member

Oh gosh sorry about that! I see your linked issue had the original error message. I just didn't put the pieces together about the missing $(shell part. Thanks for the extra info. 👍

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit 08a9a77 into getporter:master Oct 1, 2019
@dev-drprasad dev-drprasad deleted the fix-packr2-failed-to-install branch October 2, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packr2 failed to install
2 participants