Rename things from Duffle since we don't use it anymore #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't rely on duffle anymore, it's all cnab-go to handle the runtime, so I've renamed it to Runtime to help clarify what the struct really does.
We don't use duffle anymore so be more clear about what's going on, or remove outdated comments entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
We used to rely on duffle and have some internal classes and comments that still use the name. I've gone through and renamed them, and updated comments to prevent any confusion.
What issue does it fix
N/A
Notes for the reviewer
https://www.youtube.com/watch?v=Eo-KmOd3i7s
Checklist