Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapter.go): don't add empty outputs section to generated bundle #483

Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix(adapter.go): don't add empty outputs section to generated bundle #483

merged 1 commit into from
Aug 1, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Aug 1, 2019

Fixes #482

carolynvs
carolynvs approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit f1a892d into getporter:master Aug 1, 2019
@vdice vdice deleted the fix/no-outputs branch August 1, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generated bundle.json has empty outputs + fields
2 participants
@vdice @carolynvs