Add Porter Terraform Example #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
approved these changes
Jul 12, 2019
| parameters: | ||
| location: "{{ bundle.parameters.location }}" | ||
| storageAccountName: "{{ bundle.parameters.storage_account_name }}" | ||
| storageContainerName: "{{ bundle.parameters.storage_container_name }}" |
There was a problem hiding this comment.
We could add a bundle outputs section here:
outputs:
- name: cosmos-db-uri
type: string
- name: eventhubs_connection_string
type: string
If this is done, we could update docs at some point to inform the reader that they can grab a specific output via porter bundle output show cosmos-db-uri, etc. (Depends on #451)
jeremyrickard
force-pushed
the
good-terraform-example
branch
from
700f3e6 to
b125895
Compare
|
@vdice i updated this, take a look. |
vdice
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an example to the examples directory that leverages the
porter-azureandporter-terraformmixins to install, upgrade and uninstall some infrastructure.