Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug flag should apply to single invocation only #3241

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

kichristensen
Copy link
Contributor

@kichristensen kichristensen commented Oct 31, 2024

What does this change

This fixes a regression bug, where the --debug carries over to other invocations of the porter upgrade command.

What issue does it fix

Closes #3240

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen kichristensen changed the title fix: Debug flag should apply to single invocation only Debug flag should apply to single invocation only Oct 31, 2024
@kichristensen kichristensen force-pushed the nonStickyDebug branch 2 times, most recently from b5978a1 to 24b54fa Compare November 1, 2024 11:06
@kichristensen kichristensen marked this pull request as ready for review November 1, 2024 13:26
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I poked around to see if there was a better place to put this but this makes the most sense.

@schristoff schristoff merged commit 055b785 into getporter:main Nov 1, 2024
39 of 40 checks passed
@kichristensen kichristensen deleted the nonStickyDebug branch November 1, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying --debug during installation or upgrade sticks in future invocations
2 participants