Correct plugin logging

[kichristensen]

What does this change

• Makes the plugin log level controlable by the verbosity level instead of the log file level (Plugins logs are not controlled by the --verbosity flag #3189)
• Show logs from plugins with the correct level as defined by the plugin (Logs from plugins are always shown as debug logs #3188)

What issue does it fix

Closes #3189 and closes #3188

Checklist

• Did you write tests?
• Did you write documentation?
• Did you change porter.yaml or a storage document record? Update the corresponding schema file.
• If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

[kichristensen]

@schristoff I think I got a mail about a comment on this PR, but cannot seem to find it again

[kurtschenk]

Hi @kichristensen,

I don't think I am seeing the fix.

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ cleanup_docker_containers
docker run -it --network host --env PORTER_LOGS_LEVEL=debug -v /var/run/docker.sock:/var/run/docker.sock porter:v1.1.1 porter version
porter v1.1.1 (f8faad1a)

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ cleanup_docker_containers
[…]
kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ docker run -it --network host --env PORTER_LOGS_LEVEL=debug -v /var/run/docker.sock:/var/run/docker.sock porter:v1.1.1 porter list --verbosity debug
Checking database schema
Selected default plugin {"plugin-key": "mongodb-docker"}
Connecting to plugin    {"plugin-command": "/root/.porter/porter plugin run storage.porter.mongodb-docker"}
starting plugin
plugin started
waiting for RPC address
plugin address
using plugin
pulling mongo:4.0-xenial
running a mongo server in a container on port 27018
waiting for the mongo service to be ready
Initializing installation collection indices
Initializing parameter collection indices
Initializing credentials collection indices
-----------------------------------------------------
  NAMESPACE  NAME  VERSION  STATE  STATUS  MODIFIED  
-----------------------------------------------------
received EOF, stopping recv loop
plugin process exited
plugin exited

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ cleanup_docker_containers
[…]

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc/certs$ docker run -it --network host -v /var/run/docker.sock:/var/run/docker.sock porter:v1.1.1 porter list --verbosity debug
Checking database schema
Selected default plugin {"plugin-key": "mongodb-docker"}
Connecting to plugin    {"plugin-command": "/root/.porter/porter plugin run storage.porter.mongodb-docker"}
starting plugin
plugin started
waiting for RPC address
plugin address
using plugin
Initializing installation collection indices
Initializing parameter collection indices
Initializing credentials collection indices
-----------------------------------------------------
  NAMESPACE  NAME  VERSION  STATE  STATUS  MODIFIED  
-----------------------------------------------------
received EOF, stopping recv loop
plugin process exited
plugin exited
	

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ cleanup_docker_containers

[…]

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ docker run -it --network host --env PORTER_LOGS_LEVEL=debug -v /var/run/docker.sock:/var/run/docker.sock porter:v1.1.1 porter list
-----------------------------------------------------
  NAMESPACE  NAME  VERSION  STATE  STATUS  MODIFIED  
-----------------------------------------------------

Still need both in v1.1.1 above like in v1.1.0 below to get the debug detail. "--verbosity debug" alone is not enough.

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ cleanup_docker_containers
[…]

kurt@DESKTOP-ML7A32M:/mnt/c/Users/kurtsc$ docker run -it --network host --env PORTER_LOGS_LEVEL=debug --env PORTER_LOGS_STRUCTURED=true -v /var/run/docker.sock:/var/run/docker.sock porter:v1.1.0 porter list --verbosity debug
2024-09-30T15:47:18.788Z        debug   Checking database schema
2024-09-30T15:47:18.788Z        debug   Selected default plugin {"plugin-key": "mongodb-docker"}
2024-09-30T15:47:18.788Z        debug   Connecting to plugin    {"plugin-command": "/root/.porter/porter plugin run storage.porter.mongodb-docker"}
2024-09-30T15:47:18.789Z        debug   starting plugin
2024-09-30T15:47:18.791Z        debug   plugin started
2024-09-30T15:47:18.791Z        debug   waiting for RPC address
2024-09-30T15:47:18.827Z        debug   using plugin
2024-09-30T15:47:18.828Z        debug   plugin address
2024-09-30T15:47:18.949Z        debug   pulling mongo:4.0-xenial
2024-09-30T15:47:28.563Z        debug   running a mongo server in a container on port 27018
2024-09-30T15:47:28.563Z        debug   waiting for the mongo service to be ready
2024-09-30T15:47:30.620Z        debug   Initializing installation collection indices
2024-09-30T15:47:30.622Z        debug   Initializing parameter collection indices
2024-09-30T15:47:30.623Z        debug   Initializing credentials collection indices
-----------------------------------------------------
  NAMESPACE  NAME  VERSION  STATE  STATUS  MODIFIED  
-----------------------------------------------------
2024-09-30T15:47:30.627Z        debug   received EOF, stopping recv loop
2024-09-30T15:47:30.629Z        debug   plugin process exited
2024-09-30T15:47:30.629Z        debug   plugin exited

[kichristensen]

@kurtschenk Based on the output I have to agree. I will take a look

[kichristensen]

@kurtschenk I have found the error, and is working on a fix, fully covered by tests. Thank you very much for trying it out.