Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing dependency parameters on command line #3013

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Allow passing dependency parameters on command line #3013

merged 4 commits into from
Mar 19, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

The documentation states that dependency parameters can be passed on the command line with the following format, DEP#PARAM=VALUE. Currently that is not possible, this change makes it possible.

What issue does it fix

Closes #3010

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@kichristensen
Allow passing dependency parameters on command line
980d813 
The documentation states that dependency parameters can be passed on the
command line with the following format, DEP#PARAM=VALUE. Currently that
is not possible, this change makes it possible.

Signed-off-by: Kim Christensen <[email protected]>
@schristoff schristoff merged commit ed2b0de into getporter:main Mar 19, 2024
15 checks passed
@kichristensen kichristensen deleted the depParamsOverride branch June 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgettys sgettys sgettys approved these changes

@schristoff schristoff schristoff approved these changes

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency parameters cannot be specificed on the command line
3 participants
@kichristensen @schristoff @sgettys