Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: git tag -f needs moved, add permissions to publish workflows #2985

Merged
merged 3 commits into from
Feb 6, 2024
Merged

bug: git tag -f needs moved, add permissions to publish workflows #2985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afcd8ea
schristoff_removeregexmaybe
schristoff Feb 5, 2024
0977974
getting closer
schristoff Feb 6, 2024
4695abc
Merge branch 'main' into schristoff_fixmagefiletag
schristoff Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build_pipelinesrelease_template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ jobs:
- Validate-integration_test
- Validate-smoke_test
runs-on: ubuntu-latest
permissions: write-all
if: success() && inputs.shouldPublish
steps:
- name: checkout
Expand Down Expand Up @@ -161,6 +162,7 @@ jobs:
- Validate-integration_test
- Validate-smoke_test
runs-on: ubuntu-latest
permissions: write-all
if: success() && inputs.shouldPublish
steps:
- name: checkout
Expand Down
2 changes: 1 addition & 1 deletion magefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ func PublishPorter() {
// Create or update GitHub release for the permalink (canary/latest) with the version's assets (porter binaries, exec binaries and install scripts)
if info.ShouldPublishPermalink() {
// Move the permalink tag. The existing release automatically points to the tag.
must.RunV("git", "tag", info.Permalink, info.Version+"-f")
must.RunV("git", "tag", "-f", info.Permalink, info.Version)
must.RunV("git", "push", "-f", remote, info.Permalink)

releases.AddFilesToRelease(repo, info.Permalink, porterVersionDir)
Expand Down
Loading