-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Hugo theme to Hextra for the website #2897
Conversation
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
@schristoff The theme porting has almost finished, I am fixing the internal links. Way too many need fix 😵, Also, I am running |
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: Sumit Kumar Soni <[email protected]>
Hey! This is looking amazing. A couple of comments:
I am so excited for this redesign thank you for doing all this work |
I increased logo size, but the favicon doesn't seem to work as specified in their docs. I will open a issue in hextra.
hextra allows changing the hue via custom.css file and I have changed it to the red color in the porter Logo and the site now looks like this, not sure if that looks good or bad 😅.
Done 👍🏼
Done 👍🏼
Thanks <3 : ) |
Okay, we're almost there!
I think that's it, then we can merge this big PR and iterate on it from here! :) |
This is not an issue of the website, It's probably some browser extension, something like DarkReader causing the effect. Please give it a try after disabling any extension of that kind, or maybe in a different browser as well. |
You're 100% right 🤦🏻 it is darkreader good call |
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Signed-off-by: zelfroster <[email protected]>
Hey @schristoff, I am done for now on this PR. The copyright and favicon issue need to be resolved with Hextra and Unless I missed something, I think it's good to go. |
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Favicon, Footer & CNCF logo
Lemme fix the CNCF logo at the footer, just few minutes. |
Signed-off-by: zelfroster <[email protected]>
@schristoff Done Finally 🎉 |
Signed-off-by: zelfroster <[email protected]>
PR getporter#2897 moved the CLI reference file, but the CLI reference generation still points to the old location. Signed-off-by: Kim Christensen <[email protected]>
…#3129) PR #2897 moved the CLI reference file, but the CLI reference generation still points to the old location. Signed-off-by: Kim Christensen <[email protected]>
What does this change
Changes the hugo theme to Hextra for Porter website.
What issue does it fix
Closes #2885
Checklist
Reviewer Checklist