-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field-selector argument to installations list #2888
Add field-selector argument to installations list #2888
Conversation
/azp run porter-integration |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Maninderjit Bindra <[email protected]>
Signed-off-by: Maninderjit Bindra <[email protected]>
Signed-off-by: Maninderjit Bindra <[email protected]>
20332aa
to
245337f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and some comments to request changes around using reflect with installation/displayinstallation, etc.
The splitting on .
and ,
and interface{}.
Signed-off-by: Maninderjit Bindra <[email protected]>
@troy0820 I have made modifications as per our discussion. Thanks |
…eld-selector-argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much!!
What does this change
Filter output of porter installation list based on any field/combination of fields using the --field-selector". Supports '=' ,e.g. --field-selector bundle.version=0.2.0,status.action=install. All fields from the json output are supported.
Output below
What issue does it fix
Closes #2871 and #2773
Notes for the reviewer
This implementation filters to be displayed installations based on the --field-selector argument, which supports filtering by all fields in the json output of porter installation list.
Checklist
Reviewer Checklist