Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck issues #2812

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Fix shellcheck issues #2812

merged 3 commits into from
Jul 7, 2023

Conversation

Doommius
Copy link
Contributor

@Doommius Doommius commented Jul 4, 2023

fixed some issues from https://www.shellcheck.net that were given issues in pipelines using it.

What does this change

Fixed linting issues presented by shellcheck

What issue does it fix

linting issue.

Notes for the review

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Sorry, something went wrong.

fixed some issues from https://www.shellcheck.net that were given issues in pipelines using it.

Signed-off-by: Mark Jervelund <[email protected]>
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Please don't forget to add yourself to the contributors file :)

@schristoff schristoff merged commit 6a01179 into getporter:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants