Refactor the bundle adapter #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are converting a porter.yaml to a bundle.json we need the porter config file so that we can check if the upcoming dependencies2 feature flag is enabled and conditionally build out a different bundle. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
converter-refactor
branch
2 times, most recently
from
3ed32b6 to
b94b050
Compare
Stop logging directly to stdout(!) and instead log with the current span so that it is traced. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
converter-refactor
branch
from
b94b050 to
221ce97
Compare
vdice
approved these changes
May 31, 2022
carolynvs
added
the
pep003-advanced-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Pass porter config to the bundle converter
When we are converting a porter.yaml to a bundle.json we need the porter config file so that we can check if the upcoming dependencies2 feature flag is enabled and conditionally build out a different bundle.
Add context.Context to the bundle adapter
Stop logging directly to stdout(!) and instead log with the current span so that it is traced.
What issue does it fix
Part of #1939
I am breaking up some of the changes that we know that we need to support the advanced dependencies feature into small changes that we can safely review and merge now.
Notes for the reviewer
N/A
Checklist
Reviewer Checklist