Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry.ListTags #2109

Merged
merged 1 commit into from
May 31, 2022
Merged

Add registry.ListTags #2109

merged 1 commit into from
May 31, 2022

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented May 27, 2022 •
edited
Loading

What does this change

When resolving dependencies, we need to be able to query a registry for a list of the tags associated with a bundle. This will allow us to select the highest version of a bundle that matches the version range specified by a dependency.

What issue does it fix

Part of #1939

I am breaking up some of the changes that we know that we need to support the advanced dependencies feature into small changes that we can safely review and merge now.

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs
Add registry.ListTags
fdaa0fa 
When resolving dependencies, we need to be able to query a registry for
a list of the tags associated with a bundle. This will allow us to
select the highest version of a bundle that matches the version range
specified by a dependency.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs marked this pull request as ready for review May 31, 2022 13:14
@carolynvs carolynvs merged commit 058e161 into getporter:release/v1 May 31, 2022
@carolynvs carolynvs deleted the list-tags branch May 31, 2022 18:03
@carolynvs carolynvs added the pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees
No one assigned
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolynvs @vdice