Add --version flag to porter #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People never know if a CLI supports --version or a version command. So let's just support both so whatever they try will work. MAGIC!
|
OMG I looooove testing cobra in unit tests. I just realize that you can set |
vdice
approved these changes
Jul 7, 2020
cmd/porter/version_test.go
Outdated
| assert.Contains(t, out.String(), "porter v1.0.0 (abc123)") | ||
| }) | ||
|
|
||
| t.Run("command", func(t *testing.T) { |
There was a problem hiding this comment.
nit: should we update this test name to differ from the other above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
People never know if a CLI supports --version or a version command. So let's just support both so whatever they try will work. MAGIC!
What issue does it fix
Fighting muscle memory
Notes for the reviewer
Inspired by https://twitter.com/michellenoorali/status/1280517451550199808
Checklist