Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GoTool Task #1052

Merged
merged 1 commit into from
May 19, 2020
Merged

Use GoTool Task #1052

merged 1 commit into from
May 19, 2020

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented May 19, 2020

Azure Pipelines has changed how go is set up on their environments. Instead of using a script to configure GOROOT, we should now use the GoTool task. We still need an extra script to add GOPATH/bin to PATH since we rely on using tools installed there, like packr.

Our builds were failing because as part of this GOROOT moved from /usr/local/go1.13 to /usr/local/go1.13.PATCH which since we don't actually specify patch, was a bit hard to intuit. 😅

https://docs.microsoft.com/en-us/azure/devops/pipelines/ecosystems/go?view=azure-devops&tabs=go-current#set-up-go

@carolynvs carolynvs force-pushed the fix-build branch 4 times, most recently from f7cff4b to f947942 Compare May 19, 2020 16:41
Azure Pipelines has changed how go is set up on their environments.
Instead of using a script to configure GOROOT, we should now use the
GoTool task. We still need an extra script to add GOPATH/bin to PATH
since we rely on using tools installed there, like packr.
@carolynvs carolynvs marked this pull request as ready for review May 19, 2020 17:11
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@carolynvs carolynvs merged commit 091b6f6 into getporter:master May 19, 2020
@carolynvs carolynvs deleted the fix-build branch May 19, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants