Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add airgap example #1042

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Add airgap example #1042

merged 2 commits into from
Jun 9, 2020

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented May 15, 2020

What does this change

Add an example of shoving a bundle over an airgap. 🐳 💨🚜

TODO:

What issue does it fix

Needed it for a demo and people asked a lot about it in Slack.

Notes for the reviewer

  • As I wrote this I realized that our docs don't explain how to do this, so there will be follow-up PRs.
  • Found a bug in how we rename images when we copy them to another registry, need to split that out into another PR. It's in here because it broke my demo...

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs carolynvs marked this pull request as ready for review June 8, 2020 20:00
@carolynvs
Copy link
Member Author

@vdice Okay this is finally ready for review

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@carolynvs carolynvs merged commit fd7536e into getporter:master Jun 9, 2020
@carolynvs carolynvs deleted the airgapp branch June 9, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants