feat(driver_test.go): add test around docker driver config

[vdice]

What does this change

• adds a test around Docker driver config based on runtime extension data

Depends on cnabio/cnab-go#206 or some variant thereof

TODO:

• remove branch override in go.mod

What issue does it fix

Addresses a TODO lingering in code

Notes for the reviewer

Am I go mod-ing right?! All of the updated deps are coming from my branch override, right? Or is something up with my local Go cache/env that's bringing all of these in?

Checklist

• Unit Tests
• Documentation
• Schema (porter.yaml)

[carolynvs]

cnab-go pulls in a higher version of testify and packr. The packr bump pulled in a new dependency (envy), etc... It was a cascade from bumping cnab-go and its dependencies.

[carolynvs]

I don't see what caused you to need the changes in the PR to cnab-go? Can you help explain what in Porter made you need the change? I'm sure there was something that made this originally hard to work with.

[vdice]

I don't see what caused you to need the changes in the PR to cnab-go?

I added some notes in cnabio/cnab-go#206 (comment) but found we'd hit panics when applying configuration options to an otherwise uninitialized Driver instance (meaning, not actually running exec on the driver, where much of the initialization occurs), because the containerCfg and containerHostCfg members were also uninitialized (invalid references). I was hoping to support the ability to do the aforementioned, and so thought to change those fields to actual values.

[carolynvs]

This is perfect. Thanks for your work getting the plumbing into cnab-go to support it.

Can you add a converse test to verify that when we don't have privileged that it's not set on the driver? Just to check for us hard coding it accidentally like it was originally.

[carolynvs]

🚢