-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cli npm package installs on Linux/MacOS #2589
Conversation
@chadlwilson Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although unrelated, do the lint issues need fixing?
This comment was marked as outdated.
This comment was marked as outdated.
Benchmark Results
Notes
See Workflow log for more details. |
Signed-off-by: Chad Wilson <[email protected]>
Locks package at 0.5.14 since 0.5.15 seemed to introduce the problem at cthackers/adm-zip#530 Signed-off-by: Chad Wilson <[email protected]>
f81090a
to
3ced4ce
Compare
OK, fixed the lint issues here now. |
Locks adm-zip package at
0.5.14
since0.5.15
seemed to introduce the problem at cthackers/adm-zip#530See #2332 (comment) for discussion.
Also fixes lint issues caused by golang/go#60529