Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli npm package installs on Linux/MacOS #2589

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

chadlwilson
Copy link
Contributor

@chadlwilson chadlwilson commented Aug 14, 2024

Locks adm-zip package at 0.5.14 since 0.5.15 seemed to introduce the problem at cthackers/adm-zip#530

See #2332 (comment) for discussion.

Also fixes lint issues caused by golang/go#60529

@chadlwilson chadlwilson added ReleaseCandidate dependencies Pull requests that update a dependency file labels Aug 14, 2024
@gaugebot
Copy link

gaugebot bot commented Aug 14, 2024

@chadlwilson Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

zabil
zabil previously approved these changes Aug 14, 2024
Copy link
Member

@zabil zabil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although unrelated, do the lint issues need fixing?

@chadlwilson

This comment was marked as outdated.

Copy link
Contributor

Benchmark Results

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
aca081e 29% 71592 0:12.17 0
209816e 28% 70148 0:12.10 0
684d870 34% 68012 0:10.56 0
dee3c4f 25% 70096 0:14.05 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
aca081e 42% 65592 0:14.32 0
209816e 44% 67716 0:14.15 0
684d870 53% 67684 0:11.47 0
dee3c4f 53% 65820 0:11.91 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
aca081e 23% 71632 0:23.81 0
209816e 22% 74208 0:25.02 0
684d870 22% 75992 0:24.47 0
dee3c4f 22% 71980 0:24.77 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
aca081e 5% 121208 0:40.88 0
209816e 5% 128988 0:46.76 0
684d870 5% 116480 0:45.44 0
dee3c4f 5% 116932 0:44.13 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
aca081e 80% 251776 0:16.80 0
209816e 64% 262080 0:21.98 0
684d870 63% 205604 0:19.21 0
dee3c4f 60% 170384 0:19.51 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
aca081e 45% 248244 0:30.68 0
209816e 40% 218564 0:34.92 0
684d870 33% 177512 0:34.73 0
dee3c4f 35% 172016 0:31.90 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
aca081e 9% 116704 0:23.63 0
209816e 10% 122740 0:22.51 0
684d870 10% 123668 0:24.49 0
dee3c4f 9% 116004 0:23.59 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
aca081e 63% 234180 0:18.12 0
209816e 59% 210032 0:19.35 0
684d870 58% 183140 0:15.71 0
dee3c4f 55% 181064 0:17.41 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
aca081e 9% 111040 0:24.87 0
209816e 10% 126456 0:25.35 0
684d870 10% 130832 0:25.82 0
dee3c4f 9% 115564 0:24.96 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

Signed-off-by: Chad Wilson <[email protected]>
Locks package at 0.5.14 since 0.5.15 seemed to introduce
the problem at cthackers/adm-zip#530

Signed-off-by: Chad Wilson <[email protected]>
@chadlwilson
Copy link
Contributor Author

OK, fixed the lint issues here now.

@zabil zabil enabled auto-merge (squash) August 14, 2024 12:19
@zabil zabil merged commit afc97cb into getgauge:master Aug 14, 2024
18 checks passed
@chadlwilson chadlwilson deleted the fix-npm-install branch August 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ReleaseCandidate
Development

Successfully merging this pull request may close these issues.

2 participants