Fix logging lifecycles and clean up tests #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two points of feedback:
While making this PR I uncovered a fault in one of the tests which didn't show up because of the flawed teardown of logging: The empty graph tests should now show that a
/rosout
node exists and that it has one topic.I also took the liberty of cleaning up the tests to make sure that each test creates a node with a unique name, because otherwise we get spammed with warnings which might mislead someone into thinking that something is wrong with rclrs or its tests.