-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not evaluate failing mlr3::lrn chunk (#1111 hotfix) #1117
Do not evaluate failing mlr3::lrn chunk (#1111 hotfix) #1117
Conversation
eco chapter failed with
So I've tried evaluating the train stage. Whack-a-mole! https://github.com/geocompx/geocompr/actions/runs/11009162777/job/30568217959#step:4:1992 |
Latest error after commit above FYI @jannes-m:
Please prioritise this over proof-reading. |
@@ -8,6 +8,8 @@ jobs: | |||
name: Render-Book | |||
runs-on: ubuntu-latest | |||
container: geocompr/geocompr:suggests | |||
env: | |||
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for GH API maxxing out.
Latest error arises here I think:
Message:
Any ideas @Nowosad? Seems like a new one. |
@Robinlovelace my guess would be that the error is related to some code change before... |
@Nowosad there are no changes that could explain this, right? https://github.com/geocompx/geocompr/pull/1117/files |
references.Rmd
Outdated
# References {-} | ||
'` | ||
|
||
<!-- Todo: re-add if (knitr:::is_html_output()) bit? --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robinlovelace maybe try reinstate this? I looked at the changes and I cannot guess what is the source of the issue...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@Robinlovelace you may also try to render a single chapter to isolate the source of the issue |
Good idea. Additional commits to this branch welcome. |
This reverts commit b3c30b7.
Suggestion: let's merge this to check the same behaviour happens on deployment workflow. Plan to do so this evening. |
Latest hypothesis: xfun-related yihui/xfun@7dabf85 |
Again, I cannot reproduce the error in our container, ok, I should be more specific, I am using ghcr.io/geocompx/docker:qgis. Mmh, this is not the container gha is using which is geocompr/geocompr:suggests. Ok, I'll try this one as well. |
Going to merge this, it's a mixxed bag but overall positive. We can re-evaluate the chunks later is my thinking @jannes-m, sorry for the hassle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we pls revert most of the changes in the mlr3 chunks? Otw we will never know if there were breaking changes to the mlr3verse (sorry, but atm I don't use machine learning at all). We should also use the cache=TRUE, cache.lazy=FALSE stuff again. Not using this led to trouble with terra/raster in the past
No description provided.