support money 4.0, remove prophecy deprecation warnings #112
Conversation
|
What do you think about dropping support for otherwise unsupported versions of PHP in a separate pull request? |
|
@localheinz I decided to drop versions because it's hard to get the tests working with moneyphp 4.0 because of the committed composer.lock. |
|
@localheinz Dropping PHP 7.2 prevents a dependency hell. See the failing tests. With a committed composer.lock, multiple PHP versions, multiple Money versions, I decided not to split. And, while I was at it, I thought why not remove the unsupported versions. Hence I removed PHP 7.3 too. We could tag this as minor version update (2.3.0) because nothing changed in the src folder, no BC breaks. |
.github/workflows/main.yml
Outdated
| run: composer install | ||
|
|
||
| - name: Setup problem matchers for PHP | ||
| run: echo "::add-matcher::${{ runner.tool_cache }}/php.json" |
There was a problem hiding this comment.
Ha, nice, wasn't aware of this matcher!
There was a problem hiding this comment.
I took it from the Money lib
|
There's already a lot going on this PR... As far as I am concerned I'd like to keep support for PHP 7.4, but anything older (and thus EOL) can, and should, be dropped. If we assume that 7.4 becomes the "odd" one, and PHP 8.0 is the "default", then I'd rather have the CI treat 7.4 as a special case |
|
Actually what I had in mind was an optional step like so: - name: Remove lock for older PHP
if: matrix.php-version == '7.4'
run: rm composer.lockThen there is never a single |
|
I see the advantage of doing it that way, but IMHO this is over-engineered for this project. I'd rather keep things simple. |
|
@PowerKiKi I applied your PHP 7.4 suggestions. |
|
If this is fine with you @PowerKiKi and @localheinz, I will merge it in and tag 2.3.0. |
| curl -LO https://scrutinizer-ci.com/ocular.phar | ||
| php ocular.phar code-coverage:upload --format=php-clover coverage-clover.xml | ||
| - name: Upload Scrutinizer coverage | ||
| uses: sudo-bot/action-scrutinizer@latest |
There was a problem hiding this comment.
The change is totally fine with me, but I was curious if there are any advantages of using an action here ?
|
(maybe just a little squash ?) |
|
Thanks both for your quick help! |
|
Thank you for putting in the work, @frederikbosch! |
|
I see that there is a |
* support money 4.0 * remove prophecy deprecation warnings * drop unsupported php versions
No description provided.