feat: +unit test #663
Merged
feat: +unit test #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2024 11:59
iorisa
force-pushed
the
feature/unittest
branch
from
83eb54b to
d9c5809
Compare
geekan
reviewed
Jan 2, 2024
tests/metagpt/utils/test_s3.py
Outdated
| @pytest.mark.asyncio | ||
| async def test_s3_no_error(): | ||
| key = CONFIG.S3_ACCESS_KEY | ||
| CONFIG.S3_ACCESS_KEY = "YOUR_S3_ACCESS_KEY" |
There was a problem hiding this comment.
In a general sense, CONFIG is a read-only class and should not be writable
There was a problem hiding this comment.
CONFIGis a session-scoped context that supports both read and write operations.Configrepresents a configuration file and is read-only.- The root cause of the issue here is the absence of the concept of a session in the console version. Therefore, the name
CONFIGis used. - To support the concept of a session functionally, the
contextvars.ContextVardata type has been employed. - All mock session options have been changed to use the
set_contextmethod.
There was a problem hiding this comment.
There's going to be a bit tricky about that. The associated code needs to be refactored to be more straightforward. If it is a session concept, you should provide a session object, and use session.config or context.config in the session object to accurately express the context in which it is located. It needs to be refactored in the future, so you can put it here first
iorisa
force-pushed
the
feature/unittest
branch
from
66c1970 to
b7d74c6
Compare
geekan
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features