Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixed pyright complaints with SilentTQDM and made not printing default behaviour #761

Merged
merged 7 commits into from
Sep 3, 2024
Merged

feat: fixed pyright complaints with SilentTQDM and made not printing default behaviour #761

merged 7 commits into from
Sep 3, 2024

Conversation

db091756
Copy link
Member

@db091756 db091756 commented Aug 30, 2024 •
edited
Loading

…default behaviour

PR Type

  • Feature

Description

Fixed pyright complaints with SilentTQDM and made not printing default behaviour

How Has This Been Tested?

All tests pass.

Does this PR introduce a breaking change?

(Write your answer here.)

Screenshots

(Write your answer here.)

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@db091756 db091756 linked an issue Aug 30, 2024 that may be closed by this pull request
[Feature]: Allow user to silence TQDM output #404
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

Performance review

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

No significant changes to performance.

@tp832944 tp832944 self-requested a review August 30, 2024 14:55
@tp832944
Copy link
Contributor

This is worth adding to the changelog, so please do.

tp832944
tp832944 requested changes Aug 30, 2024
View reviewed changes
coreax/score_matching.py Show resolved Hide resolved
coreax/util.py Outdated Show resolved Hide resolved
documentation/source/conf.py Outdated Show resolved Hide resolved
coreax/score_matching.py Outdated Show resolved Hide resolved
@db091756 db091756 requested a review from tp832944 August 30, 2024 15:27
@github-actions GitHub Actions
Copy link
Contributor

Performance review

No significant changes to performance.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Performance review

No significant changes to performance.

tp832944
tp832944 requested changes Sep 3, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
coreax/util.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Performance review

No significant changes to performance.

@db091756 db091756 requested a review from tp832944 September 3, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Performance review

No significant changes to performance.

@db091756 db091756 merged commit 28bd00e into main Sep 3, 2024
23 checks passed
@db091756 db091756 deleted the feat/silent-tqdm branch September 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tp832944 tp832944 tp832944 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow user to silence TQDM output
2 participants
@db091756 @tp832944