-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gz sdf
command on windows
#1344
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Build using gazebo-tooling/release-tools#1063: |
Codecov Report
@@ Coverage Diff @@
## sdf13 #1344 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 128 128
Lines 17090 17090
=======================================
Hits 14968 14968
Misses 2122 2122
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green. Nice!
Unfortunately not. The CI that actually runs the UNIT_gz_TESt is https://build.osrfoundation.org/job/sdformat-pr-win/792/ and it's failing. |
That is showing builds with the |
Signed-off-by: Addisu Z. Taddese <[email protected]>
More complete fix in #1374. Will partially backport that once merged. |
🦟 Bug fix
Fixes #1321
Summary
#1339 fixed some issues related to the
gz
tool on windows, but as mentioned in #1339 (comment), theUNIT_gz_TEST
weren't running.Needs gazebo-tooling/release-tools#1063
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.