Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Requires
Summary
Reduce duplication with other Gazebo libraries by depending on
gz-cmake
.There's been a previous attempt at migrating to
gz-cmake
in PR 6, but at the time we decided against it because it would be complicated to support two versions installing theign
executable. With the move togz
(see gazebo-tooling/release-tools#739), that's no longer an issue.Test it
gz-plugin
, and check that thegz plugin
CLI workscolcon test
and check thatUNIT_gz_TEST
andrubocop
passedcolcon build --cmake-target doc
, then navigate tobuild/ignition-tools2/doxygen/html/
and check that the documentation site is correctly generatedcolcon build --cmake-target codecheck
and check it passesChecklist
Consider updating Python bindings (if the library has them)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸