removed unneeded plugin update

[jennuine]

🦟 Bug fix

Summary

When a plugin was added an Update was called immediately. With #497 updates are also being called in a loop, which was causing deadlocks since both could be called at the same time. This PR removes the initial update (after the plugin is inserted) since updates are already happening periodically.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[chapulina]

Thanks for cleaning this up! Works for me. Let's just wait for CI results.

[iche033]

ran into this issue on ign-gazebo4 so ported the fix over and confirmed that the issue is fixed.

JointPositionController tests are failing on CI though

[chapulina]

JointPositionController tests are failing on CI though

Should be fixed by waiting for updates in 20cdc9f

[codecov]

Codecov Report

Merging #944 (20cdc9f) into ign-gazebo3 (638e97c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           ign-gazebo3     #944      +/-   ##
===============================================
- Coverage        77.84%   77.80%   -0.05%     
===============================================
  Files              220      220              
  Lines            12589    12579      -10     
===============================================
- Hits              9800     9787      -13     
- Misses            2789     2792       +3     

Impacted Files	Coverage Δ
src/gui/Gui.cc	67.20% <ø> (+0.27%)	⬆️
src/gui/GuiRunner.cc	94.64% <0.00%> (+0.89%)	⬆️
src/gui/plugins/plot_3d/Plot3D.cc	43.47% <0.00%> (-4.35%)	⬇️
...int_position_controller/JointPositionController.cc	62.28% <0.00%> (+1.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638e97c...20cdc9f. Read the comment docs.