Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Mesh Tutorial #915

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Conversation

francocipollone
Copy link
Contributor

Signed-off-by: Franco Cipollone [email protected]

🎉 New feature

The mesh tutorial here created is migrated from Google Doc to an actual tutorial in ign-gazebo
Tutorial Author: @RafiAbdullah

Some pics:
image

image

Test it

I share here the generated HTML in case you want to take a look:

model_and_optimize_meshes_tutorial.zip

After extracting the files you can use your favorite browser by doing: (e.g. using google chrome)

google-chrome model_and_optimize_meshes.html

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Franco Cipollone <[email protected]>

Co-authored-by: RafiAbdullah <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #915 (563b6b2) into ign-gazebo3 (15b456b) will not change coverage.
The diff coverage is n/a.

❗ Current head 563b6b2 differs from pull request most recent head b121607. Consider uploading reports for the commit b121607 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #915   +/-   ##
============================================
  Coverage        77.94%   77.94%           
============================================
  Files              215      215           
  Lines            12077    12077           
============================================
  Hits              9413     9413           
  Misses            2664     2664           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b456b...b121607. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one technical comment about the anchors and a question that I'm checking with Rafi. Otherwise looks good to me 👍

tutorials/model_and_optimize_meshes.md Outdated Show resolved Hide resolved
tutorials/model_and_optimize_meshes.md Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 34ac465 into ign-gazebo3 Jul 17, 2021
@chapulina chapulina deleted the francocipollone/add_mesh_tutorial branch July 17, 2021 01:20
@francocipollone
Copy link
Contributor Author

Thanks for pushing the changes! @chapulina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants