Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #868

Closed
wants to merge 13 commits into from
Closed

3 ➡️ 4 #868

wants to merge 13 commits into from

Conversation

jennuine
Copy link
Contributor

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 13 commits May 26, 2021 22:45
* Fix issue not configuring links added after start

Signed-off-by: Jorge Perez <[email protected]>

* Add a test checking the fix

Signed-off-by: Jorge Perez <[email protected]>
* Change the diff_drive_system test to cover min_acceleration
  and min_velocity limits. Added those limits to the .sdf file.

Signed-off-by: LolaSegura <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Franco Cipollone <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine requested a review from chapulina as a code owner June 19, 2021 00:39
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jun 19, 2021
@chapulina
Copy link
Contributor

Oh, is this a duplicate of #866? 😅

@chapulina
Copy link
Contributor

I can update that PR to include the latest PRs, or we can decline that one and work with this one

@jennuine
Copy link
Contributor Author

I knew I missed something🤦‍♀️ forgot to check the open PRs.. do you mind to update that PR please? I'll close this one

@jennuine jennuine closed this Jun 19, 2021
@jennuine jennuine deleted the jennuine/3_to_4 branch June 19, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants