Setting the intiial velocity for a model or joint #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
changed the title
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
==========================================
- Coverage 64.88% 64.87% -0.01%
==========================================
Files 235 235
Lines 16889 16958 +69
==========================================
+ Hits 10958 11002 +44
- Misses 5931 5956 +25
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Mar 18, 2021
|
should we add any test ? |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
|
Ok, tests, examples and docs added. Mind taking another quick look, @ahcorde ? |
ahcorde
reviewed
Mar 19, 2021
| }); | ||
| server.AddSystem(testSystem.systemPtr); | ||
|
|
||
| // Run server and check that vehicle didn't move |
There was a problem hiding this comment.
Suggested change
| // Run server and check that vehicle didn't move | |
| // Run server and check that vehicle move |
Signed-off-by: Louise Poubel <[email protected]>
Closed
chapulina
added a commit
that referenced
this pull request
Jul 30, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Jul 30, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Jul 30, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Aug 4, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Aug 4, 2021
Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Let the user set an initial velocity through the
VelocityControlplugin orJointControllerplugin.I'm using this for a demo.
I'll come back to add tests and docs, just opening in time for feature freeze 🥶
Test it
I'll add it to the example world.
Checklist
TODODoneTODODoneTODODoneUpdated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸