Save http URIs (fix tests) #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
This was referenced Aug 12, 2020
ahcorde
pushed a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: Louise Poubel <[email protected]>
This was referenced Sep 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDF generator was not taking into consideration the case where Fuel URLs are propagated through the ECS, because that was difficult to happen before gazebosim/gz-fuel-tools#85.
This PR just makes it so the full URLs are not completely broken when saving the world. A more complete fix would be to support the EntityGeneratorConfig options.